[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: rt5514: Add 16ms delay on dmic init

Duncan Laurie (Code Review) gerrit at coreboot.org
Tue Aug 29 17:45:43 CEST 2017


Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/21271


Change subject: mb/google/eve: rt5514: Add 16ms delay on dmic init
......................................................................

mb/google/eve: rt5514: Add 16ms delay on dmic init

Add a 16ms delay to DMIC init by the kernel driver in order to
prevent an audible 'pop' noise when starting to record.

BUG=b:63413023
TEST=manual testing to ensure this device property is present in SSDT:

Name (_DSD, Package () {
  ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301")
  Package () {
    Package () {
      "realtek,dmic-init-delay",
      0x10
    }
  }
})

Change-Id: If9160ce6992153ba49719029de336595bbf4ae72
Signed-off-by: Duncan Laurie <dlaurie at google.com>
---
M src/mainboard/google/eve/devicetree.cb
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/21271/1

diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index 2e017f8..37e3b1e 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -300,6 +300,11 @@
 				register "hid" = ""10EC5514""
 				register "name" = ""RT54""
 				register "desc" = ""Realtek RT5514""
+				register "property_count" = "1"
+				# Set the DMIC initial delay to 16ms to avoid pop noise
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""realtek,dmic-init-delay""
+				register "property_list[0].integer" = "16"
 				device i2c 57 on end
 			end
 		end # I2C #4

-- 
To view, visit https://review.coreboot.org/21271
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9160ce6992153ba49719029de336595bbf4ae72
Gerrit-Change-Number: 21271
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170829/77668ee2/attachment-0001.html>


More information about the coreboot-gerrit mailing list