[coreboot-gerrit] Change in coreboot[master]: acpigen: Add stop gpio control to power resource

Furquan Shaikh (Code Review) gerrit at coreboot.org
Tue Aug 29 02:39:45 CEST 2017


Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/21249 )

Change subject: acpigen: Add stop gpio control to power resource
......................................................................

acpigen: Add stop gpio control to power resource

There is at least one I2C device (being used by Soraka) that has 3
controls -- enable, reset and stop. If the stop gpio is not put into
the right state when turning off the device in suspend mode, then it
causes leakage. Thus, we need control in power resource to be able to
stop the device when entering suspend state.

This change adds stop gpio control only to I2C device since that is
the one known to use it. If a similar need arises for SPI device, stop
gpio can be added to it as well.

BUG=b:64987428
TEST=Verified on soraka that touchscreen stop is correctly configured
on suspend.

Change-Id: Iae5ec7eb3972c5c7f80956d60d0d3c321bbefb0f
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/arch/x86/acpi_device.c
M src/arch/x86/include/arch/acpi_device.h
M src/drivers/i2c/generic/chip.h
M src/drivers/i2c/generic/generic.c
M src/drivers/spi/acpi/acpi.c
5 files changed, 26 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/21249/2
-- 
To view, visit https://review.coreboot.org/21249
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iae5ec7eb3972c5c7f80956d60d0d3c321bbefb0f
Gerrit-Change-Number: 21249
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170829/91728a82/attachment.html>


More information about the coreboot-gerrit mailing list