[coreboot-gerrit] Change in libgfxinit[master]: dp training: Allow to adjust pre-emphasis during clock recovery

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21216 )

Change subject: dp training: Allow to adjust pre-emphasis during clock recovery
......................................................................

dp training: Allow to adjust pre-emphasis during clock recovery

That's not demanded by the spec but there are sinks in the wild that
need it.

Change-Id: Ibef5236ca771e0e02beb4e76650ffb6974657846
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/21216
Reviewed-by: Felix Held <felix-coreboot at felixheld.de>
---
M common/hw-gfx-dp_training.adb
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Felix Held: Looks good to me, approved
  Nico Huber: Verified



diff --git a/common/hw-gfx-dp_training.adb b/common/hw-gfx-dp_training.adb
index e7411d0..a2d00a7 100644
--- a/common/hw-gfx-dp_training.adb
+++ b/common/hw-gfx-dp_training.adb
@@ -257,8 +257,9 @@
 
       -- According to DP spec, only change preemphasis during channel
       -- equalization. What to do if sink requests it during clock recovery?
-      -- Linux always accepts new values from the sink, we don't, for now.
-      if Success and then (CR_Was_Done and not EQ_Done) then
+      -- Linux always accepts new values from the sink, we too, now: There
+      -- are sinks in the wild that need this.
+      if Success and not EQ_Done then
          Train_Set.Pre_Emph :=
             DP_Info.Max_Requested_Emph (Status, Link);
          if Train_Set.Pre_Emph > Max_Pre_Emph (Port, Train_Set)

-- 
To view, visit https://review.coreboot.org/21216
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibef5236ca771e0e02beb4e76650ffb6974657846
Gerrit-Change-Number: 21216
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170828/2db1d3f5/attachment.html>