[coreboot-gerrit] Change in libhwbase[master]: direct pci: Always initialize Address_State
Nico Huber (Code Review)
gerrit at coreboot.org
Mon Aug 28 22:17:18 CEST 2017
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21205 )
Change subject: direct pci: Always initialize Address_State
......................................................................
direct pci: Always initialize Address_State
Let Initialize() always initialize the Address_State. This is not only
the expected behaviour but also necessary to share the contract with
other implementations.
Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/21205
Reviewed-by: Adrian-Ken Rueegsegger <ken at codelabs.ch>
---
M common/direct/hw-pci-dev.adb
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Nico Huber: Verified
Adrian-Ken Rueegsegger: Looks good to me, approved
diff --git a/common/direct/hw-pci-dev.adb b/common/direct/hw-pci-dev.adb
index 9bd7d1d..3d76521 100644
--- a/common/direct/hw-pci-dev.adb
+++ b/common/direct/hw-pci-dev.adb
@@ -108,6 +108,8 @@
begin
if MMConf_Base /= 0 then
MM.Set_Base_Address (MMConf_Base);
+ else
+ MM.Set_Base_Address (Config.Default_MMConf_Base);
end if;
Success := MMConf_Base /= 0 or Config.Default_MMConf_Base_Set;
end Initialize;
--
To view, visit https://review.coreboot.org/21205
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0454dfd6c36f7d4298edeec5b84d929e3160eb7b
Gerrit-Change-Number: 21205
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken at codelabs.ch>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170828/9ae93f5d/attachment.html>
More information about the coreboot-gerrit
mailing list