[coreboot-gerrit] Change in libgfxinit[master]: gma: Fix refined contract of Initialize()
Nico Huber (Code Review)
gerrit at coreboot.org
Mon Aug 28 22:11:13 CEST 2017
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/21207 )
Change subject: gma: Fix refined contract of Initialize()
......................................................................
gma: Fix refined contract of Initialize()
To be compatible with HW.PCI.Dev implementations that do actual register
accesses, we have to account for hardware state updates.
Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be
Signed-off-by: Nico Huber <nico.h at gmx.de>
Reviewed-on: https://review.coreboot.org/21207
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Reviewed-by: Adrian-Ken Rueegsegger <ken at codelabs.ch>
---
M common/hw-gfx-gma.adb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nico Huber: Verified
Patrick Georgi: Looks good to me, approved
Adrian-Ken Rueegsegger: Looks good to me, but someone else must approve
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 94f3ceb..101de18 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -301,7 +301,7 @@
with
Refined_Global =>
(In_Out =>
- (Config.Valid_Port_GPU,
+ (Config.Valid_Port_GPU, Dev.PCI_State,
Registers.Register_State, Port_IO.State),
Input =>
(Time.State),
--
To view, visit https://review.coreboot.org/21207
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I86e42163d7847f7011bcf9a0ef5c2c7f25b4b1be
Gerrit-Change-Number: 21207
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Adrian-Ken Rueegsegger <ken at codelabs.ch>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170828/97cb90c2/attachment.html>
More information about the coreboot-gerrit
mailing list