[coreboot-gerrit] Change in coreboot[master]: Kconfig: move Mainboard selection to the top level

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/21238 )

Change subject: Kconfig: move Mainboard selection to the top level
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

I think we'd be better served by just moving the mainboard menu to the top entry.

I'd like to hear other people's opinions.

https://review.coreboot.org/#/c/21238/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/21238/1//COMMIT_MSG@10
PS1, Line 10: It should be choosen as the first thing before configuring anything else.
While this is true, I don't think it needs to be at the top level - It's not something that gets updated frequently.

If other people disagree, I can update the kconfig lint tool to allow options at the top level.


https://review.coreboot.org/#/c/21238/1/src/mainboard/Kconfig
File src/mainboard/Kconfig:

https://review.coreboot.org/#/c/21238/1/src/mainboard/Kconfig@11
PS1, Line 11: source "src/mainboard/*/Kconfig"
If we go forward with this patch, this should go into the menu as well.



-- 
To view, visit https://review.coreboot.org/21238
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic21abc69a3430475c232d8050626d6bca98c5514
Gerrit-Change-Number: 21238
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 28 Aug 2017 15:42:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170828/8b28002c/attachment.html>