[coreboot-gerrit] Change in coreboot[master]: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code

Patrick Rudolph (Code Review) gerrit at coreboot.org
Mon Aug 28 17:15:32 CEST 2017


Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/21225 )

Change subject: mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code
......................................................................

mb/gigabyte/ga-b75m-d3*/acpi: Remove redundant code

Remove obsolete code. The same settings are always done in southbridge.

Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
Reviewed-on: https://review.coreboot.org/21225
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
M src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c
2 files changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved



diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
index 05a21ae..bbf3241 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
@@ -38,9 +38,6 @@
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
 	memset((void *)gnvs, 0, sizeof(*gnvs));
-	gnvs->apic = 1;
-	gnvs->mpen = 1; /* Enable Multi Processing */
-	gnvs->pcnt = dev_count_cpu();
 
 	/* Disable USB ports in S3 by default */
 	gnvs->s3u0 = 0;
diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c
index 05a21ae..bbf3241 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3v/acpi_tables.c
@@ -38,9 +38,6 @@
 void acpi_create_gnvs(global_nvs_t *gnvs)
 {
 	memset((void *)gnvs, 0, sizeof(*gnvs));
-	gnvs->apic = 1;
-	gnvs->mpen = 1; /* Enable Multi Processing */
-	gnvs->pcnt = dev_count_cpu();
 
 	/* Disable USB ports in S3 by default */
 	gnvs->s3u0 = 0;

-- 
To view, visit https://review.coreboot.org/21225
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic893ddbace73ae8b122c4fb675febc7d1e0b5da9
Gerrit-Change-Number: 21225
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170828/ee9f07e7/attachment.html>


More information about the coreboot-gerrit mailing list