[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 )

Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
......................................................................


Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c
File src/southbridge/intel/bd82x6x/pch.c:

https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c@259
PS6, Line 259: southbridge_intel_bd82x6x_config
> In order to make the 80-char-per-line limit happy, I have to write it like 
just write it like this:

    static void pch_pcie_devicetree_update(
    		struct southbridge_intel_bd82x6x_config *config)

(two tabs indent is common in this case)


https://review.coreboot.org/#/c/21178/6/src/southbridge/intel/bd82x6x/pch.c@312
PS6, Line 312: 		return;
Not that I care, but others demand that code follows declarations.
So this should come after the `u32 reg32;`.



-- 
To view, visit https://review.coreboot.org/21178
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad
Gerrit-Change-Number: 21178
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 26 Aug 2017 11:24:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170826/fb723c25/attachment.html>