[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x: make hotplug map consistent to remapped ports

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 )

Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports
......................................................................


Patch Set 5:

(4 comments)

https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c
File src/southbridge/intel/bd82x6x/pch.c:

https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@258
PS5, Line 258: void *chip_info
No need for `void *` here, just give it the correct type please.


https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@261
PS5, Line 261:  = NULL
The initialization is unnecessary and compilers might even warn
about it.


https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@292
PS5, Line 292: 			if (config) {
Check in pch_pcie_enable() instead please.


https://review.coreboot.org/#/c/21178/5/src/southbridge/intel/bd82x6x/pch.c@313
PS5, Line 313: 
If you really want to check `config` for `NULL`, do it here and just
`return` in case. By the time you check it in pci_pcie_devicetree_update()
it's already been dereferenced multiple times.



-- 
To view, visit https://review.coreboot.org/21178
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I28c4eaf82fb52fe793dfa2f824f14686b80951ad
Gerrit-Change-Number: 21178
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 26 Aug 2017 09:07:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170826/aadefb81/attachment.html>