[coreboot-gerrit] Change in coreboot[master]: arch/x86: Add Kconfig option for ACPI \_PR CPU name string

Marc Jones (Code Review) gerrit at coreboot.org
Sat Aug 26 03:19:39 CEST 2017


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/21210


Change subject: arch/x86: Add Kconfig option for ACPI \_PR CPU name string
......................................................................

arch/x86: Add Kconfig option for ACPI \_PR CPU name string

Add a Kconfig option to change the \PR.CPxx name string. This
provides some flexibility when working with table not generated
by coreboot.

Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/arch/x86/Kconfig
M src/arch/x86/acpigen.c
2 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21210/1

diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 14827cf..65feba1 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -249,3 +249,12 @@
 	  Set to allow the payload to control normal/fallback image recovery.
 	  Note that it is the responsibility of the payload to reset the
 	  normal boot bit to 1 after each successsful boot.
+
+config ACPI_CPU_STRING
+	string
+	default "\\_PR.CP%02d"
+	depends on HAVE_ACPI_TABLES
+	help
+	  Sets the ACPI name srting in the processor scope as written by
+	  the acpigen function. Default is \_PR.CPxx. Note that you need
+	  the \ escape character in the string.
diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index f9690b3..758386d 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -338,7 +338,7 @@
 void acpigen_write_processor(u8 cpuindex, u32 pblock_addr, u8 pblock_len)
 {
 /*
-	Processor (\_PR.CPUcpuindex, cpuindex, pblock_addr, pblock_len)
+	Processor (\_PR.CPcpuindex, cpuindex, pblock_addr, pblock_len)
 	{
 */
 	char pscope[16];
@@ -346,7 +346,7 @@
 	acpigen_write_len_f();
 
 	snprintf(pscope, sizeof(pscope),
-		 "\\_PR.CP%02d", (unsigned int) cpuindex);
+		 CONFIG_ACPI_CPU_STRING, (unsigned int) cpuindex);
 	acpigen_emit_namestring(pscope);
 	acpigen_emit_byte(cpuindex);
 	acpigen_emit_dword(pblock_addr);

-- 
To view, visit https://review.coreboot.org/21210
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc0c56783c6da80501e2177de96a414b592cb74f
Gerrit-Change-Number: 21210
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170826/d08b55a3/attachment.html>


More information about the coreboot-gerrit mailing list