[coreboot-gerrit] Change in coreboot[master]: nb/intel/i440bx/debug.c: Bugfix and cleanup

Keith Hui (Code Review) gerrit at coreboot.org
Fri Aug 25 21:51:48 CEST 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21203

to look at the new patch set (#2).

Change subject: nb/intel/i440bx/debug.c: Bugfix and cleanup
......................................................................

nb/intel/i440bx/debug.c: Bugfix and cleanup

Fix dump_pci_device() broken by commit 65b72ab5 (Drop print_ implementation
from non-romcc boards) in 2015 (!) where only one in 16 bytes were being
dumped.

Also remove the #if made redundant by commit aef8542 (Compile debug.c
only if CONFIG_DEBUG_RAM_SETUP) as this whole file is only compiled in
that case.

Also clean up headers that were included twice.

Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/northbridge/intel/i440bx/debug.c
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/21203/2
-- 
To view, visit https://review.coreboot.org/21203
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60e272b29417039feb15540e49d7300f86e5ed21
Gerrit-Change-Number: 21203
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Hui <buurin at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170825/d55fa3e8/attachment.html>


More information about the coreboot-gerrit mailing list