[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: Camera PMIC runtime power control

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/20741 )

Change subject: mb/google/soraka: Camera PMIC runtime power control
......................................................................


Patch Set 8:

(1 comment)

Is

https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants/soraka/gpio.c
File src/mainboard/google/poppy/variants/soraka/gpio.c:

https://review.coreboot.org/#/c/20741/8/src/mainboard/google/poppy/variants/soraka/gpio.c@146
PS8, Line 146: PAD_CFG_GPO(GPP_C11, 0, DEEP),
> this change should be done for poppy/gpio.c as well.
Is there any update on this. We are currently waiting on this change to verify the behavior of camera on boot-up and confirm power consumption in suspend states. For now we can skip the about suggestion of separate gpio table. But we at least need following two things:
1. This gpio change needs to be done for poppy as well
2. Did you confirm the tests that Rajmohan mentioned along with the changes in this CL?



-- 
To view, visit https://review.coreboot.org/20741
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23b0c0a887c9eb5d29b89f14aebba273b01228e0
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 8
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass at intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Lakshmi G Prasad <lakshmi.g.prasad at intel.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani at intel.com>
Gerrit-Reviewer: Ricky Liang <jcliang at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Tomasz Figa <tfiga at google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 22 Aug 2017 06:14:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170822/0a0fdce0/attachment.html>