[coreboot-gerrit] Change in coreboot[master]: google/beltino: fix LED polarity for mccloud variant
Matt DeVillier (Code Review)
gerrit at coreboot.org
Mon Aug 21 23:37:56 CEST 2017
Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/21102
to look at the new patch set (#2).
Change subject: google/beltino: fix LED polarity for mccloud variant
......................................................................
google/beltino: fix LED polarity for mccloud variant
The LED polarity was set incorrectly, fix using values derived
from original Chromium sources:
branch firmware-mccloud-5827.B, ToT
src/mainboard/google/mccloud/smihandler.c
src/mainboard/google/mccloud/romstage.c
TEST: boot google/mccloud, observe power LED on normally,
blinking in S3/S4, and off in S5.
Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/beltino/variants/mccloud/led.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/21102/2
--
To view, visit https://review.coreboot.org/21102
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1f63eebbccb48fcf8543188db390b23045d843e
Gerrit-Change-Number: 21102
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170821/463fdb40/attachment.html>
More information about the coreboot-gerrit
mailing list