[coreboot-gerrit] Change in coreboot[master]: google/cyan: convert to variant configuration

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon Aug 21 21:51:58 CEST 2017


Hello Paul Menzel, build bot (Jenkins), Martin Roth, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/21126

to look at the new patch set (#2).

Change subject: google/cyan: convert to variant configuration
......................................................................

google/cyan: convert to variant configuration

Set up cyan to be the baseboard for other Google Braswell
boards, to be added in subsequent commits.

This commit keeps code common to all Google Braswell boards in
the cyan baseboard, separates out the board-specific bits into
the new cyan variant, and defines the I2C ACPI devices such that
they can be easily reused for other variants. It also switches
the trackpad/touchscreen interrupts from edge to level, for
better performance/compatibility as was done with all previous
Google boards.

Additionally, a few hardcoded values are replaced with variables,
and a few typos/formatting errors are corrected.

Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/cyan/Kconfig.name
M src/mainboard/google/cyan/Makefile.inc
A src/mainboard/google/cyan/acpi/codec_maxim.asl
M src/mainboard/google/cyan/acpi/dptf.asl
M src/mainboard/google/cyan/acpi/mainboard.asl
M src/mainboard/google/cyan/acpi/superio.asl
A src/mainboard/google/cyan/acpi/touchscreen_elan.asl
A src/mainboard/google/cyan/acpi/trackpad_elan.asl
M src/mainboard/google/cyan/board_info.txt
M src/mainboard/google/cyan/boardid.c
M src/mainboard/google/cyan/ramstage.c
M src/mainboard/google/cyan/smihandler.c
R src/mainboard/google/cyan/variants/cyan/Makefile.inc
A src/mainboard/google/cyan/variants/cyan/board_info.txt
R src/mainboard/google/cyan/variants/cyan/devicetree.cb
R src/mainboard/google/cyan/variants/cyan/gpio.c
A src/mainboard/google/cyan/variants/cyan/include/variant/acpi/dptf.asl
A src/mainboard/google/cyan/variants/cyan/include/variant/acpi/mainboard.asl
R src/mainboard/google/cyan/variants/cyan/include/variant/onboard.h
R src/mainboard/google/cyan/variants/cyan/spd.c
21 files changed, 380 insertions(+), 267 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/21126/2
-- 
To view, visit https://review.coreboot.org/21126
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabbbad16efa9cfa79338f4e94d0771779900d8d9
Gerrit-Change-Number: 21126
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170821/94eaf3be/attachment.html>


More information about the coreboot-gerrit mailing list