[coreboot-gerrit] Change in coreboot[master]: google/cyan: Remove support for pre-EVT board

Matt DeVillier (Code Review) gerrit at coreboot.org
Mon Aug 21 07:52:00 CEST 2017


Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/21123 )

Change subject: google/cyan: Remove support for pre-EVT board
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21123/1/src/mainboard/google/cyan/smihandler.c
File src/mainboard/google/cyan/smihandler.c:

https://review.coreboot.org/#/c/21123/1/src/mainboard/google/cyan/smihandler.c@a155
PS1, Line 155: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
This I'm not sure about -- all other Braswell boards added this to later board revisions and excluded earlier ones (prior to support for earlier revisions being dropped), but cyan does the reverse.  Is that correct?



-- 
To view, visit https://review.coreboot.org/21123
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29b32da8064e0743cc9c5df02ce7d3441459ee8f
Gerrit-Change-Number: 21123
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Comment-Date: Mon, 21 Aug 2017 05:52:00 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170821/60d4afac/attachment.html>


More information about the coreboot-gerrit mailing list