[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Move SPI lock down config after PCI enumeration

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/21064 )

Change subject: soc/intel/skylake: Move SPI lock down config after PCI enumeration
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/21064/1/src/soc/intel/skylake/finalize.c
File src/soc/intel/skylake/finalize.c:

https://review.coreboot.org/#/c/21064/1/src/soc/intel/skylake/finalize.c@128
PS1, Line 128: 	const struct device *dev1 = dev_find_slot(0, PCH_DEVFN_LPC);
remove this and use "dev" itself now.

dev = PCH_DEV_PMC
const struct soc_intel_skylake_config *config = dev->chip_info;


https://review.coreboot.org/#/c/21064/1/src/soc/intel/skylake/finalize.c@133
PS1, Line 133: 		dev = PCH_DEV_PMC;
remove this


https://review.coreboot.org/#/c/21064/1/src/soc/intel/skylake/lockdown.c
File src/soc/intel/skylake/lockdown.c:

https://review.coreboot.org/#/c/21064/1/src/soc/intel/skylake/lockdown.c@104
PS1, Line 104: 	/* Bios Interface Lock */
             : 	if (config->LockDownConfigBiosInterface == 0)
             : 		fast_spi_set_bios_interface_lock_down();
             : 
             : 	/* Bios Lock */
             : 	if (config->LockDownConfigBiosLock == 0)
             : 		fast_spi_set_lock_enable();
             : 
             : 	/* SPIEiss */
             : 	if (config->LockDownConfigSpiEiss == 0)
             : 		fast_spi_set_eiss();
i'm going to use new name config like spilockdown and lpclockdown to make all lockdown under a single



-- 
To view, visit https://review.coreboot.org/21064
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5a952656e51d3bf365917b90d3056b46f899c5
Gerrit-Change-Number: 21064
Gerrit-PatchSet: 1
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 17 Aug 2017 09:24:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170817/5787745f/attachment.html>