[coreboot-gerrit] Change in coreboot[master]: amd/pi/hudson: Convert 48Mhz en to read/write32

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/21033 )

Change subject: amd/pi/hudson: Convert 48Mhz en to read/write32
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/21033/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/21033/1//COMMIT_MSG@7
PS1, Line 7: 48Mhz en
It looks like this got modified.  I'd change it to MHz and enabled.


https://review.coreboot.org/#/c/21033/1/src/southbridge/amd/pi/hudson/early_setup.c
File src/southbridge/amd/pi/hudson/early_setup.c:

https://review.coreboot.org/#/c/21033/1/src/southbridge/amd/pi/hudson/early_setup.c@272
PS1, Line 272: (u32)
This cast should come out.



-- 
To view, visit https://review.coreboot.org/21033
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e09757e5eea1eaf9b76921ad032ad2b79c14c5
Gerrit-Change-Number: 21033
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Comment-Date: Wed, 16 Aug 2017 14:41:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/8f81a740/attachment.html>