[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Clear GPIO overrides

John E. Kabat (Code Review) gerrit at coreboot.org
Wed Aug 16 16:28:10 CEST 2017


Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21046

to review the following change.


Change subject: amd/padmelon: Clear GPIO overrides
......................................................................

amd/padmelon: Clear GPIO overrides

Remove the GPIO settings left over from Bettong.  The following
settings are no longer applicable:
 * 64: GBe / x4 Mux
 * 86: SATA switch

New settings will be added as features are turned on.

Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/BiosCallOuts.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/21046/1

diff --git a/src/mainboard/amd/padmelon/BiosCallOuts.c b/src/mainboard/amd/padmelon/BiosCallOuts.c
index 152c724..91c5efe 100644
--- a/src/mainboard/amd/padmelon/BiosCallOuts.c
+++ b/src/mainboard/amd/padmelon/BiosCallOuts.c
@@ -51,8 +51,6 @@
 const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts);
 
 static const GPIO_CONTROL oem_padmelon_gpio[] = {
-	{86, Function1, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE | DrvStrengthSel_12mA},
-	{64, Function1, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE | DrvStrengthSel_12mA},
 	{-1}
 };
 /**

-- 
To view, visit https://review.coreboot.org/21046
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57e5baddf0dc8dcb89d8fbc19f373887c40cd3c3
Gerrit-Change-Number: 21046
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/094cba8c/attachment.html>


More information about the coreboot-gerrit mailing list