[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Remove board ID file

[John E. Kabat (Code Review)]

Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21044

to review the following change.


Change subject: amd/padmelon: Remove board ID file
......................................................................

amd/padmelon: Remove board ID file

Padmelon does not use an identifying scheme like Bettong.  Remove
the support associated with determining the ID.

Change-Id: I34fb1d61016e84b8bd12b21de65fed40c5e2e4d9
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/Makefile.inc
D src/mainboard/amd/padmelon/boardid.c
2 files changed, 0 insertions(+), 53 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/21044/1

diff --git a/src/mainboard/amd/padmelon/Makefile.inc b/src/mainboard/amd/padmelon/Makefile.inc
index cfcc9c0..72cd042 100644
--- a/src/mainboard/amd/padmelon/Makefile.inc
+++ b/src/mainboard/amd/padmelon/Makefile.inc
@@ -15,9 +15,7 @@
 
 romstage-y += BiosCallOuts.c
 romstage-y += OemCustomize.c
-romstage-y += boardid.c
 
 ramstage-y += BiosCallOuts.c
 ramstage-y += OemCustomize.c
 ramstage-$(CONFIG_HUDSON_IMC_FWM) += fchec.c
-ramstage-y += boardid.c
diff --git a/src/mainboard/amd/padmelon/boardid.c b/src/mainboard/amd/padmelon/boardid.c
deleted file mode 100644
index 5cbb1a7..0000000
--- a/src/mainboard/amd/padmelon/boardid.c
+++ /dev/null
@@ -1,51 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 Advanced Micro Devices, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <stdint.h>
-#include <arch/io.h>
-#include <southbridge/amd/common/amd_defs.h>
-#include <boardid.h>
-
-/**
- *todo: remove this file
- *
- *Bettong uses 3 GPIO(5-7) pins to identify board.
- *The GPIO ports are mapped to MMIO space.
- *The GPIO value and board version are mapped as follow:
- *GPIO5 GPIO6 GPIO7 Version
- *  0     0     0      A
- *  0     0     1      B
- *  ......
- *  1     1     1      H
- */
-uint8_t board_id(void)
-{
-	void *gpiommioaddr;
-	u8  value = 0;
-	u8  boardrev = 0;
-	char boardid;
-
-	gpiommioaddr = (void *)AMD_SB_ACPI_MMIO_ADDR + 0x1500;
-	value = read8(gpiommioaddr + (7 << 2) + 2); /* agpio7: board_id2 */
-	boardrev = value & 1;
-	value = read8(gpiommioaddr + (6 << 2) + 2); /* agpio6: board_id1 */
-	boardrev |= (value & 1) << 1;
-	value = read8(gpiommioaddr + (5 << 2) + 2); /* agpio5: board_id0 */
-	boardrev |= (value & 1) << 2;
-
-	boardid = 'A' + boardrev;
-
-	return boardid;
-}

-- 
To view, visit https://review.coreboot.org/21044
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34fb1d61016e84b8bd12b21de65fed40c5e2e4d9
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/b65f2ea9/attachment.html>