[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Remove XHCI1 setting

John E. Kabat (Code Review) gerrit at coreboot.org
Wed Aug 16 16:27:51 CEST 2017


Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21043

to review the following change.


Change subject: amd/padmelon: Remove XHCI1 setting
......................................................................

amd/padmelon: Remove XHCI1 setting

Family 15h Models 60h-6Fh have only a single xHCI controller.
Remove the disable for the second one.

Change-Id: I26f525b282b6e6ffebed98fc6de3bbac135ed34d
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/BiosCallOuts.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/21043/1

diff --git a/src/mainboard/amd/padmelon/BiosCallOuts.c b/src/mainboard/amd/padmelon/BiosCallOuts.c
index e316474..152c724 100644
--- a/src/mainboard/amd/padmelon/BiosCallOuts.c
+++ b/src/mainboard/amd/padmelon/BiosCallOuts.c
@@ -72,7 +72,6 @@
 		FchParams_reset->FchReset.SataEnable = hudson_sata_enable();
 		FchParams_reset->FchReset.IdeEnable = hudson_ide_enable();
 		FchParams_reset->FchReset.Xhci0Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
-		FchParams_reset->FchReset.Xhci1Enable = FALSE;
 		FchParams_reset->EarlyOemGpioTable = oem_padmelon_gpio;
 	} else if (StdHeader->Func == AMD_INIT_ENV) {
 		FCH_DATA_BLOCK *FchParams_env = (FCH_DATA_BLOCK *)FchData;
@@ -85,7 +84,6 @@
 			FchParams_env->Usb.Xhci0Enable = TRUE;
 		else
 			FchParams_env->Usb.Xhci0Enable = FALSE;
-		FchParams_env->Usb.Xhci1Enable = FALSE;
 		FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */
 
 		/* SD configuration */

-- 
To view, visit https://review.coreboot.org/21043
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26f525b282b6e6ffebed98fc6de3bbac135ed34d
Gerrit-Change-Number: 21043
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/8f05fb47/attachment.html>


More information about the coreboot-gerrit mailing list