[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Enable the SATA controller

John E. Kabat (Code Review) gerrit at coreboot.org
Wed Aug 16 16:27:41 CEST 2017


Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21042

to review the following change.


Change subject: amd/padmelon: Enable the SATA controller
......................................................................

amd/padmelon: Enable the SATA controller

Change-Id: Ide5f0c9d63746a80a83a886dfb62e3475657cea0
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/BiosCallOuts.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21042/1

diff --git a/src/mainboard/amd/padmelon/BiosCallOuts.c b/src/mainboard/amd/padmelon/BiosCallOuts.c
index 7abb69a..e316474 100644
--- a/src/mainboard/amd/padmelon/BiosCallOuts.c
+++ b/src/mainboard/amd/padmelon/BiosCallOuts.c
@@ -69,6 +69,8 @@
 		FCH_RESET_DATA_BLOCK *FchParams_reset = (FCH_RESET_DATA_BLOCK *)FchData;
 		printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");
 
+		FchParams_reset->FchReset.SataEnable = hudson_sata_enable();
+		FchParams_reset->FchReset.IdeEnable = hudson_ide_enable();
 		FchParams_reset->FchReset.Xhci0Enable = IS_ENABLED(CONFIG_HUDSON_XHCI_ENABLE);
 		FchParams_reset->FchReset.Xhci1Enable = FALSE;
 		FchParams_reset->EarlyOemGpioTable = oem_padmelon_gpio;
@@ -86,7 +88,6 @@
 		FchParams_env->Usb.Xhci1Enable = FALSE;
 		FchParams_env->Usb.USB30PortInit = 8; /* 8: If USB3 port is unremoveable. */
 
-		/* sata configuration */
 		/* SD configuration */
 		FchParams_env->Sd.SdSlotType = 1; /* eMMC */
 	}

-- 
To view, visit https://review.coreboot.org/21042
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide5f0c9d63746a80a83a886dfb62e3475657cea0
Gerrit-Change-Number: 21042
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/ff9f84c4/attachment.html>


More information about the coreboot-gerrit mailing list