[coreboot-gerrit] Change in coreboot[master]: amd/padmelon: Enable the console

[John E. Kabat (Code Review)]

Hello Marshall Dawson,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21037

to review the following change.


Change subject: amd/padmelon: Enable the console
......................................................................

amd/padmelon: Enable the console

The system has two RS-232 ports connected to a Fintek F81803.  Set
up the console on the first one.  The superio's CLKIN is driven by
the APU's OSCOUT2 so it must be enabled.  The APU's internal
UART signals are NCs so remove the configure_hudson_uart().

Change-Id: I482146b9f0acb1bb5468f8bc92c231f76bd3cb04
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/padmelon/Kconfig
M src/mainboard/amd/padmelon/romstage.c
2 files changed, 8 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/21037/1

diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig
index 9d89b07..7f75dc4 100644
--- a/src/mainboard/amd/padmelon/Kconfig
+++ b/src/mainboard/amd/padmelon/Kconfig
@@ -26,6 +26,8 @@
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_8192
 	select GFXUMA
+	select SUPERIO_FINTEK_F81803A
+	select SUPERIO_FINTEK_COMMON_ROMSTAGE
 
 config MAINBOARD_DIR
 	string
diff --git a/src/mainboard/amd/padmelon/romstage.c b/src/mainboard/amd/padmelon/romstage.c
index 29cd8a7..7f29002 100644
--- a/src/mainboard/amd/padmelon/romstage.c
+++ b/src/mainboard/amd/padmelon/romstage.c
@@ -23,6 +23,10 @@
 #include <northbridge/amd/pi/agesawrapper.h>
 #include <northbridge/amd/pi/agesawrapper_call.h>
 #include <southbridge/amd/pi/hudson/hudson.h>
+#include <superio/fintek/common/fintek.h>
+#include <superio/fintek/f81803a/f81803a.h>
+
+#define SERIAL_DEV PNP_DEV(0x4e, F81803A_SP1)
 
 void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 {
@@ -35,10 +39,9 @@
 
 	if (!cpu_init_detectedx && boot_cpu()) {
 		post_code(0x30);
+		hudson_clk_output_48Mhz(2);
+		fintek_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
 
-#if IS_ENABLED(CONFIG_HUDSON_UART)
-		configure_hudson_uart();
-#endif
 		post_code(0x31);
 		console_init();
 	}

-- 
To view, visit https://review.coreboot.org/21037
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I482146b9f0acb1bb5468f8bc92c231f76bd3cb04
Gerrit-Change-Number: 21037
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat <sljkrr at gmail.com>
Gerrit-Reviewer: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170816/fb093f26/attachment.html>