[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Sideband lock skipped in FSP and done in coreboot

[Barnali Sarkar (Code Review)]

Hello dhaval v sharma, Subrata Banik, Balaji Manigandan, Rizwan Qureshi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/20956

to look at the new patch set (#4).

Change subject: soc/intel/skylake: Sideband lock skipped in FSP and done in coreboot
......................................................................

soc/intel/skylake: Sideband lock skipped in FSP and done in coreboot

The Sideband Acces locking code is skipped from FSP by setting an
FSP-S UPD called PchSbAccessUnlock This locking is being done in
coreboot during finalize.c.

This is done because Coreboot was failing to disable HECI1 device
using Sideband interface during finalize.c if FSP already locks
the Sideband access mechanism before that.

So, as a solution, coreboot passes an UPD to skip the locking
in FSP, and in finalize.c, after disabling HECI, it removes the
Sideband access.

BUG=b:63877089
BRANCH=none
TEST=Build and boot poppy to check lspci not showing Intel ME
controller in the PCI device list.

Change-Id: I8dba4c97480200507969b0f2873337f97bd2ff6a
Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
M src/soc/intel/skylake/chip_fsp20.c
M src/soc/intel/skylake/finalize.c
2 files changed, 43 insertions(+), 12 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/20956/4
-- 
To view, visit https://review.coreboot.org/20956
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8dba4c97480200507969b0f2873337f97bd2ff6a
Gerrit-Change-Number: 20956
Gerrit-PatchSet: 4
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170814/8b3b30bb/attachment.html>