[coreboot-gerrit] Change in coreboot[master]: mb/google/soraka: GPIO config should not reset during warm reset

Rizwan Qureshi (Code Review) gerrit at coreboot.org
Mon Aug 14 08:13:44 CEST 2017


Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/20994


Change subject: mb/google/soraka: GPIO config should not reset during warm reset
......................................................................

mb/google/soraka: GPIO config should not reset during warm reset

Setting GPIO pad reset config to DEEP will reset te gpio configuration
across warm reset, set it to RSMRST to preserve the configuration.
Also, GPIO pad reset configs for GPP and GPD pads are not same and SoC
definitions have been updated use the appropriate one.

BUG=b:64386481

Change-Id: If32f839144b9201dc23e95c7572b595a70248286
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
---
M src/mainboard/google/poppy/variants/soraka/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/20994/1

diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c
index 6e0a54f..313378c 100644
--- a/src/mainboard/google/poppy/variants/soraka/gpio.c
+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c
@@ -370,7 +370,7 @@
 /* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {
 	/* B8  : SRCCLKREQ3# ==> WLAN_PE_RST */
-	PAD_CFG_GPO(GPP_B8, 0, DEEP),
+	PAD_CFG_GPO(GPP_B8, 0, GPP_RSMRST),
 
 #if IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM)
 	/* B15 : GSPI0_CS# ==> PCH_SPI_H1_3V3_CS_L */

-- 
To view, visit https://review.coreboot.org/20994
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If32f839144b9201dc23e95c7572b595a70248286
Gerrit-Change-Number: 20994
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170814/23cd4b5e/attachment.html>


More information about the coreboot-gerrit mailing list