[coreboot-gerrit] Change in coreboot[master]: nb/amd/amdfam10/debug.c: Fix building with DEBUG_SMBUS
Arthur Heymans (Code Review)
gerrit at coreboot.org
Sat Aug 12 20:06:01 CEST 2017
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20970
Change subject: nb/amd/amdfam10/debug.c: Fix building with DEBUG_SMBUS
......................................................................
nb/amd/amdfam10/debug.c: Fix building with DEBUG_SMBUS
Was presumably missed when linking most amd fam10 files in
75a3d1fb7c: "amdfam10: Perform major include ".c" cleanup".
Change-Id: Iebe8aa1c4c3019414c6a23404cc5dc7f668cd8eb
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/amd/amdfam10/debug.c
M src/northbridge/amd/amdfam10/debug.h
2 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/20970/1
diff --git a/src/northbridge/amd/amdfam10/debug.c b/src/northbridge/amd/amdfam10/debug.c
index 067c299..762295b 100644
--- a/src/northbridge/amd/amdfam10/debug.c
+++ b/src/northbridge/amd/amdfam10/debug.c
@@ -18,6 +18,9 @@
#include <arch/io.h>
#include <device/pci_def.h>
#include <delay.h>
+#include "amdfam10.h"
+
+extern int spd_read_byte(u32 device, u32 address);
void print_debug_addr(const char *str, void *val)
{
@@ -222,7 +225,7 @@
if ((j & 0xf) == 0) {
printk(BIOS_DEBUG, "\n%02x: ", j);
}
- status = smbus_read_byte(device, j);
+ status = spd_read_byte(device, j);
if (status < 0) {
break;
}
@@ -241,7 +244,7 @@
if ((j & 0xf) == 0) {
printk(BIOS_DEBUG, "\n%02x: ", j);
}
- status = smbus_read_byte(device, j);
+ status = spd_read_byte(device, j);
if (status < 0) {
break;
}
@@ -259,12 +262,12 @@
printk(BIOS_DEBUG, "\n");
for (device = 1; device < 0x80; device++) {
int j;
- if (smbus_read_byte(device, 0) < 0) continue;
+ if (spd_read_byte(device, 0) < 0) continue;
printk(BIOS_DEBUG, "smbus: %02x", device);
for (j = 0; j < 256; j++) {
int status;
u8 byte;
- status = smbus_read_byte(device, j);
+ status = spd_read_byte(device, j);
if (status < 0) {
break;
}
diff --git a/src/northbridge/amd/amdfam10/debug.h b/src/northbridge/amd/amdfam10/debug.h
index a4ecfe9..0afa1b3 100644
--- a/src/northbridge/amd/amdfam10/debug.h
+++ b/src/northbridge/amd/amdfam10/debug.h
@@ -18,6 +18,7 @@
#include <inttypes.h>
#include "pci.h"
+#include "amdfam10.h"
void print_debug_addr(const char *str, void *val);
void print_debug_pci_dev(u32 dev);
--
To view, visit https://review.coreboot.org/20970
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebe8aa1c4c3019414c6a23404cc5dc7f668cd8eb
Gerrit-Change-Number: 20970
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170812/3b6d7975/attachment.html>
More information about the coreboot-gerrit
mailing list