[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x200: Add ACPI methods to set battery thresholds

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/20913 )

Change subject: mb/lenovo/x200: Add ACPI methods to set battery thresholds
......................................................................


Patch Set 3:

> Why don't you use existing interface to make coreboot compatible
 > with tpacpi-bat and thinkpad_acpi? They use the following ACPI
 > methods:
 > * BCCS
 > * BCSS
 > * BICS
 > * BDSS
 > * PSSS
 > They allow to set thresholds, inhibit charge, peak shift, ...

Now that I read the spec I think it's certainly possible to reimplement those at least partially.


-- 
To view, visit https://review.coreboot.org/20913
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Wed, 09 Aug 2017 07:29:29 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170809/2bb87a37/attachment.html>