[coreboot-gerrit] Change in coreboot[master]: lint: update commit message check

Martin Roth (Code Review) gerrit at coreboot.org
Wed Aug 9 04:32:03 CEST 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/20920


Change subject: lint: update commit message check
......................................................................

lint: update commit message check

- Update the commit message check from a lint-stable test to a
lint-extended test.
- Add the check for signed-off-by to the commit-msg hook

Change-Id: I8be8aef25730d988c7cf1586ae66ecb839d5f756
Signed-off-by: Martin Roth <martinroth at google.com>
---
M util/gitconfig/commit-msg
R util/lint/lint-extended-020-signed-off-by
2 files changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/20920/1

diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg
index 82f0581..2eef752 100755
--- a/util/gitconfig/commit-msg
+++ b/util/gitconfig/commit-msg
@@ -169,5 +169,8 @@
 	git hash-object -t commit --stdin
 }
 
-
+if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then
+	printf "\nError: No Signed-off-by line in the commit message.\n"
+	exit 1
+fi
 add_ChangeId
diff --git a/util/lint/lint-stable-020-signed-off-by b/util/lint/lint-extended-020-signed-off-by
similarity index 100%
rename from util/lint/lint-stable-020-signed-off-by
rename to util/lint/lint-extended-020-signed-off-by

-- 
To view, visit https://review.coreboot.org/20920
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8be8aef25730d988c7cf1586ae66ecb839d5f756
Gerrit-Change-Number: 20920
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170809/dfadf33a/attachment.html>


More information about the coreboot-gerrit mailing list