[coreboot-gerrit] Change in coreboot[master]: [WIP]mb/lenovo/x200: Add ACPI methods to set battery thresholds

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20913 )

Change subject: [WIP]mb/lenovo/x200: Add ACPI methods to set battery thresholds
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/20913/1/src/mainboard/lenovo/x200/acpi/bat_thresh.asl
File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:

PS1: 
I think we agreed to keep the tree consistent in the old syntax
for the moment.


https://review.coreboot.org/#/c/20913/1/src/mainboard/lenovo/x200/acpi/bat_thresh.asl@32
PS1, Line 32: 1
Why not place them below BAT0/BAT1? instead of numbering the
methods? (not to mention that it's weird to have a different
numbering, 1 based here, 0 based there)



-- 
To view, visit https://review.coreboot.org/20913
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia049407cea7a60887ecba7b7c96e5000473865dd
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Tue, 08 Aug 2017 19:09:55 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170808/ed63d9aa/attachment.html>