[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge/raminit: Add Kconfig option for fuses

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/20907 )

Change subject: nb/intel/sandybridge/raminit: Add Kconfig option for fuses
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/20907/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/20907/1/src/northbridge/intel/sandybridge/raminit_common.c@406
PS1, Line 406: TCK_1333MHZ
> Is faster than both ivy and sandy can run but that's not an issue I suppose
Ivybridge supports this frequency, but there's no board in tree that does. At the end the value here doesn't matter, but I don't want to return 0...


https://review.coreboot.org/#/c/20907/1/src/northbridge/intel/sandybridge/raminit_common.c@443
PS1, Line 443: if (cfg->max_mem_clock_mhz >= 1066)
             : 			return TCK_1066MHZ;
> unrelated but should be adapted for ivy bridge since that one can run faste
Yes, at the moment only 666mhz and 933mhz is being used. As this commit removes 933 I don't care that much.



-- 
To view, visit https://review.coreboot.org/20907
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35dd78a02bcaafce8ba522d253c795d7835bacae
Gerrit-Change-Number: 20907
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 08 Aug 2017 18:07:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170808/87410e42/attachment.html>