[coreboot-gerrit] Change in coreboot[master]: [WIP]console/Kconfig: fix SPI flash console dependencies

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Aug 7 01:26:00 CEST 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/20892


Change subject: [WIP]console/Kconfig: fix SPI flash console dependencies
......................................................................

[WIP]console/Kconfig: fix SPI flash console dependencies

Some chipset don't implement SPI write functions in all stages in
which case this option won't compile.

Change-Id: I713389ef9ed5e965fc34b590a86f4b5e2e84d304
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/console/Kconfig
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/20892/1

diff --git a/src/console/Kconfig b/src/console/Kconfig
index c0e4a8c..3b4b678 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -236,7 +236,8 @@
 config CONSOLE_SPI_FLASH
 	bool "SPI Flash console output"
 	default n
-	select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if !COMMON_CBFS_SPI_WRAPPER
+	depends on SPI_FLASH
+	depends on BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY || COMMON_CBFS_SPI_WRAPPER
 	help
 	  Send coreboot debug output to the SPI Flash in the FMAP CONSOLE area
 

-- 
To view, visit https://review.coreboot.org/20892
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I713389ef9ed5e965fc34b590a86f4b5e2e84d304
Gerrit-Change-Number: 20892
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170806/2290ebc5/attachment-0001.html>


More information about the coreboot-gerrit mailing list