[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Fix build with armv7-eabi cross compiler

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue Aug 1 11:41:29 CEST 2017


Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/20836


Change subject: util/cbfstool: Fix build with armv7-eabi cross compiler
......................................................................

util/cbfstool: Fix build with armv7-eabi cross compiler

We recently changed all PACKED, __PACKED, __attribute__((packed)) ... to
__packed to gain some consistency. In cbfstool we use compiler.h to
provide that where necessary.

The cross compiler I use doesn't provide __packed by itself, but liblz4
doesn't compensate for that. Therefore include compiler.h, and to avoid
adding dependencies to non-liblz4 code, do so through the command line.

Change-Id: I581e45639ac3e103af7c16793e8effe2e632dec7
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
M util/cbfstool/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/20836/1

diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc
index 950092f..8e4d8b6 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.inc
@@ -131,7 +131,7 @@
 
 $(objutil)/cbfstool/%.o: $(top)/util/cbfstool/lz4/lib/%.c
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@))\n"
-	$(HOSTCC) $(TOOLCPPFLAGS) $(TOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $<
+	$(HOSTCC) $(TOOLCPPFLAGS) $(TOOLCFLAGS) $(HOSTCFLAGS) -include $(top)/util/cbfstool/compiler.h -c -o $@ $<
 
 $(objutil)/cbfstool/cbfstool: $(addprefix $(objutil)/cbfstool/,$(cbfsobj))
 	printf "    HOSTCC     $(subst $(objutil)/,,$(@)) (link)\n"

-- 
To view, visit https://review.coreboot.org/20836
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I581e45639ac3e103af7c16793e8effe2e632dec7
Gerrit-Change-Number: 20836
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170801/949aa469/attachment.html>


More information about the coreboot-gerrit mailing list