[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Change reset type on incomplete ramini...

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded a new change for review. ( https://review.coreboot.org/19506 )

Change subject: nb/intel/x4x/raminit: Change reset type on incomplete raminit reset
......................................................................

nb/intel/x4x/raminit: Change reset type on incomplete raminit reset

If the system boots on an incomplete/failed raminit it tries to do a
hot reset. On this hot reset a different path is followed which fails
to boot (the hot reset path only works if raminit previously
succeeded).

This can be fixed by issuing a cold reset instead of a hot reset.

Change-Id: Idbcf034c3777a64cc3fb92dc603d10470a6c8cb6
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/raminit.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/19506/1

diff --git a/src/northbridge/intel/x4x/raminit.c b/src/northbridge/intel/x4x/raminit.c
index 7d352f1..f852181 100644
--- a/src/northbridge/intel/x4x/raminit.c
+++ b/src/northbridge/intel/x4x/raminit.c
@@ -330,7 +330,7 @@
 		pci_write_config8(PCI_DEV(0, 0, 0), 0xf0, reg8 |  (1 << 2));
 
 		printk(BIOS_DEBUG, "Reset...\n");
-		outb(0x6, 0xcf9);
+		outb(0xe, 0xcf9);
 		asm ("hlt");
 	}
 	pmcon2 |= 0x80;

-- 
To view, visit https://review.coreboot.org/19506
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbcf034c3777a64cc3fb92dc603d10470a6c8cb6
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>