[coreboot-gerrit] Change in coreboot[master]: libpayload/gdb: fix unused variable warning

Patrick Georgi (Code Review) gerrit at coreboot.org
Sat Apr 29 07:34:10 CEST 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19482 )

Change subject: libpayload/gdb: fix unused variable warning
......................................................................


libpayload/gdb: fix unused variable warning

input_underrun is defined but not used. A reasonably new compiler,
enabled warnings and warnings-as-error make the build break for no good
reason.

Change-Id: Ibeb7ba53aad5738938093ab7b34695c9c99c9afe
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Reviewed-on: https://review.coreboot.org/19482
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc at marcjonesconsulting.com>
---
M payloads/libpayload/gdb/transport.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marc Jones: Looks good to me, approved



diff --git a/payloads/libpayload/gdb/transport.c b/payloads/libpayload/gdb/transport.c
index 8f73bb0..5b575d0 100644
--- a/payloads/libpayload/gdb/transport.c
+++ b/payloads/libpayload/gdb/transport.c
@@ -22,8 +22,6 @@
 static const int timeout_us = 100 * 1000;
 static const char output_overrun[] = "GDB output buffer overrun (try "
 				     "increasing reply.size)!\n";
-static const char input_underrun[] = "GDB input message truncated (bug or "
-				     "communication problem)?\n";
 
 /* Serial-specific glue code... add more transport layers here when desired. */
 

-- 
To view, visit https://review.coreboot.org/19482
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibeb7ba53aad5738938093ab7b34695c9c99c9afe
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins)



More information about the coreboot-gerrit mailing list