[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Sean Paul (Code Review)]

Sean Paul has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................


Patch Set 3:

(5 comments)

Looks very solid, just a couple small nits

https://review.coreboot.org/#/c/19477/3/src/soc/rockchip/rk3399/display.c
File src/soc/rockchip/rk3399/display.c:

PS3, Line 63: 
            : 
If you're going to remove this (and HDMI down below), you should delete their entries in the header as well.


PS3, Line 120: 		detected_mode = VOP_MODE_MIPI;
You're not doing detection any longer, so just remove detected_mode and use conf->vop_mode directly


https://review.coreboot.org/#/c/19477/3/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

PS3, Line 193: big
*bigger


PS3, Line 429: 	rk_mipi_dsi_dcs_transfer(&rk_mipi, MIPI_DCS_EXIT_SLEEP_MODE);
Check return value?


PS3, Line 431: 	rk_mipi_dsi_dcs_transfer(&rk_mipi, MIPI_DCS_SET_DISPLAY_ON);
here too


-- 
To view, visit https://review.coreboot.org/19477
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02475eefb187c619c614b1cd20e97074bc8d917f
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Sean Paul <seanpaul at chromium.org>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: Yes