[coreboot-gerrit] Change in coreboot[master]: arch/x86: Share storage data structures between early stages

[Lee Leahy (Code Review)]

Lee Leahy has posted comments on this change. ( https://review.coreboot.org/19300 )

Change subject: arch/x86: Share storage data structures between early stages
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/19300/3/src/arch/x86/Kconfig
File src/arch/x86/Kconfig:

PS3, Line 244: 
             : # Allocate space in CAR to share the driver storage structures between stages
             : config CAR_DRIVERS_STORAGE
             : 	bool
             : 	default n
> If we need this, could it go in drivers/storage/kconfig instead of here?
CAR_DRIVERS_STORAGE Kconfig value removed


https://review.coreboot.org/#/c/19300/3/src/arch/x86/car.ld
File src/arch/x86/car.ld:

PS3, Line 47: CONFIG_CAR_DRIVERS_STORAGE
> can this just be CONFIG_DRIVERS_STORAGE, and we always allocate it if we're
Using DRIVERS_STORAGE instead as requested.


-- 
To view, visit https://review.coreboot.org/19300
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20a01b850a31df9887a428bf07ca476c8410d33e
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes