[coreboot-gerrit] Change in coreboot[master]: mainboard: add support for lenovo x1 carbon gen 1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/16994 )

Change subject: mainboard: add support for lenovo x1 carbon gen 1
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/16994/8/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
File src/mainboard/lenovo/x1_carbon_gen1/Kconfig:

Line 46: 	default 0xf8000000
> I'll try to use the default
It increases usable mmio region by 128MiB.


https://review.coreboot.org/#/c/16994/8/src/mainboard/lenovo/x1_carbon_gen1/gpio.c
File src/mainboard/lenovo/x1_carbon_gen1/gpio.c:

Line 18: const struct pch_gpio_set1 pch_gpio_set1_mode = {
It was common sense to remove all values that are 0. Also only GPIOs should have a direction configured, and only GPIOs with direction OUTPUT should have a level configured.


-- 
To view, visit https://review.coreboot.org/16994
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97c8e01a3ce0577d7dc9e8df7d33db3b155fe3d6
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes