[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use ITSS common code
Martin Roth (Code Review)
gerrit at coreboot.org
Fri Apr 28 16:28:32 CEST 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/19236 )
Change subject: soc/intel/apollolake: Use ITSS common code
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/#/c/19236/12/src/soc/intel/apollolake/include/soc/itss.h
File src/soc/intel/apollolake/include/soc/itss.h:
PS12, Line 20: ITSS_MAX_IRQ
Should this file #include the header where ITSS_MAX_IRQ is defined?
--
To view, visit https://review.coreboot.org/19236
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id265505cfc106668aea25ad93e114fe20736b700
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list