[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use common/block/uart code

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded a new change for review. ( https://review.coreboot.org/19491 )

Change subject: soc/intel/apollolake: Use common/block/uart code
......................................................................

soc/intel/apollolake: Use common/block/uart code

Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542
Signed-off-by: Aamir Bohra <aamir.bohra at intel.com>
---
M src/soc/intel/apollolake/uart.c
1 file changed, 2 insertions(+), 24 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/19491/1

diff --git a/src/soc/intel/apollolake/uart.c b/src/soc/intel/apollolake/uart.c
index 70d034f..3db460a 100644
--- a/src/soc/intel/apollolake/uart.c
+++ b/src/soc/intel/apollolake/uart.c
@@ -20,14 +20,12 @@
  * shouldn't cause any fragmentation.
  */
 
-#include <console/uart.h>
 #include <device/device.h>
 #include <device/pci.h>
-#include <device/pci_ids.h>
-#include <soc/pci_ids.h>
+#include <intelblocks/uart.h>
 #include <soc/pci_devs.h>
 
-static void aplk_uart_read_resources(struct device *dev)
+void pch_uart_read_resources(struct device *dev)
 {
 	pci_dev_read_resources(dev);
 
@@ -39,23 +37,3 @@
 				CONFIG_CONSOLE_UART_BASE_ADDRESS >> 10, 4, 0);
 	}
 }
-
-static struct device_operations uart_ops = {
-	.read_resources   = aplk_uart_read_resources,
-	.set_resources    = pci_dev_set_resources,
-	.enable_resources = pci_dev_enable_resources,
-	.init             = pci_dev_init,
-	.enable           = DEVICE_NOOP
-};
-
-static const unsigned short uart_ids[] = {
-	PCI_DEVICE_ID_APOLLOLAKE_UART0, PCI_DEVICE_ID_APOLLOLAKE_UART1,
-	PCI_DEVICE_ID_APOLLOLAKE_UART2, PCI_DEVICE_ID_APOLLOLAKE_UART3,
-	0
-};
-
-static const struct pci_driver uart_driver __pci_driver = {
-	.ops     = &uart_ops,
-	.vendor  = PCI_VENDOR_ID_INTEL,
-	.devices = uart_ids
-};

-- 
To view, visit https://review.coreboot.org/19491
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92c654d59f1642bcd7c95de80dcc641bf816b542
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>