[coreboot-gerrit] Change in coreboot[master]: cbgfx: Add portrait screen support

[Anonymous Coward (Code Review)]

nickey.yang at rock-chips.com has posted comments on this change. ( https://review.coreboot.org/19474 )

Change subject: cbgfx: Add portrait screen support
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19474/1//COMMIT_MSG
Commit Message:

PS1, Line 9: do
> does
Done


https://review.coreboot.org/#/c/19474/1/payloads/libpayload/drivers/video/graphics.c
File payloads/libpayload/drivers/video/graphics.c:

Line 157: 	/* Calculate canvas size & offset. Canvas is always square. */
> This comment should be changed now, maybe
Done


PS1, Line 160: canvas
> I think what Paul wants you to do, in case that's not quite clear, is this:
Done


-- 
To view, visit https://review.coreboot.org/19474
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66fee6d73654e736a2db4a3d191f030c52a23e0d
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-Reviewer: nickey.yang at rock-chips.com
Gerrit-HasComments: Yes