[coreboot-gerrit] Change in coreboot[master]: scarlet/gru: skip usbphy1 setup for Scarlet

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19489 )

Change subject: scarlet/gru: skip usbphy1 setup for Scarlet
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19489/2/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:

Line 253: 	if (!IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET))
It doesn't look great to have these strewn all over the place. Rather than that, you could change the struct definition in rk3399/include/soc/grf.h to look like this:

 reserved11[3];
 usbphy_ctrl[2][26 + 6]; /* 26 PHY regs, 6 reserved padding regs */
 reserved13[0x720];

Then you can refactor this function to take an integer argument and just have this in mainboard_init():

 setup_usb(0);
 if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET))
   setup_usb(1);


-- 
To view, visit https://review.coreboot.org/19489
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66e0d8a235cc9057964f7abca32bc692d41e88fd
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes