[coreboot-gerrit] Change in coreboot[master]: vboot: Separate board name and version number in FWID with a...

[Julius Werner (Code Review)]

Hello Patrick Georgi,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19487

to review the following change.


Change subject: vboot: Separate board name and version number in FWID with a dot
......................................................................

vboot: Separate board name and version number in FWID with a dot

It's standard practice in vboot that the FWID consists of
<board_name>.<version_number> (e.g. Google_Kevin.8785.57.0). In fact,
some tools rely on this and cut the string at the first dot to
separate the two.

The current Kconfig default in coreboot instead leads to ugly,
parser-breaking FWIDs like Google_Kevin4.5-1234-5678abcd. This patch
fixes that.

Change-Id: I65cd5285c69e2e485d55a41a65d735f6a2291c16
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/vboot/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/19487/1

diff --git a/src/vboot/Kconfig b/src/vboot/Kconfig
index c517323..f8aa572 100644
--- a/src/vboot/Kconfig
+++ b/src/vboot/Kconfig
@@ -206,7 +206,7 @@
 
 config VBOOT_FWID_VERSION
 	string "Firmware ID version"
-	default "$(KERNELVERSION)"
+	default ".$(KERNELVERSION)"
 	help
 	  This is the second part of the FWID written to various regions of a
 	  vboot firmware image to identify its version.

-- 
To view, visit https://review.coreboot.org/19487
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65cd5285c69e2e485d55a41a65d735f6a2291c16
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>