[coreboot-gerrit] Change in coreboot[master]: cbgfx: Add portrait screen support

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19474 )

Change subject: cbgfx: Add portrait screen support
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19474/1/payloads/libpayload/drivers/video/graphics.c
File payloads/libpayload/drivers/video/graphics.c:

Line 157: 	/* Calculate canvas size & offset, assuming the screen is landscape */
This comment should be changed now, maybe

 /* Calculate canvas size & offset. Canvas is always square. */


PS1, Line 160: screen
> Before and below `canvas` is used here. It’s the same as per the assignment
I think what Paul wants you to do, in case that's not quite clear, is this:

 canvas.size.width = screen.size.width;
 canvas.size.height = canvas.size.width;

(The lines need to be flipped so the assignment makes sense with canvas on the right side.)


-- 
To view, visit https://review.coreboot.org/19474
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66fee6d73654e736a2db4a3d191f030c52a23e0d
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: nickey.yang at rock-chips.com
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shunqian Zheng <zhengsq at rock-chips.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes