[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: switch touchpad devicetree to i2c-hid and cro...

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/19461 )

Change subject: mb/google/eve: switch touchpad devicetree to i2c-hid and cros_ec i2c device
......................................................................


mb/google/eve: switch touchpad devicetree to i2c-hid and cros_ec i2c device

The new touchpad firmware uses i2c-hid instead of custom reporting
protocol. The touchpad also exposed another slave address (0x1e) for
kernel to communicate with the touchpad EC.

Change-Id: Iecaf14f7b8aed836120569e9ade9c3115bc00264
Signed-off-by: Wei-Ning Huang <wnhuang at google.com>
Reviewed-on: https://review.coreboot.org/19461
Tested-by: build bot (Jenkins)
Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/eve/devicetree.cb
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Duncan Laurie: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index 275ee8a..1305f9c 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -241,12 +241,18 @@
 			end
 		end # I2C #1
 		device pci 15.2 on
-			chip drivers/i2c/generic
-				register "hid" = ""GOOG5400""
-				register "desc" = ""Touchpad""
-				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ACPI0C50""
+				register "generic.desc" = ""Touchpad""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)"
+				register "hid_desc_reg_offset" = "0x1"
 				device i2c 49 on end
 			end
+			chip drivers/i2c/generic
+				register "hid" = ""GOOG0008""
+				register "desc" = ""Touchpad EC Interface""
+				device i2c 1e on end
+			end
 		end # I2C #2
 		device pci 15.3 off end # I2C #3
 		device pci 16.0 on  end # Management Engine Interface 1

-- 
To view, visit https://review.coreboot.org/19461
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecaf14f7b8aed836120569e9ade9c3115bc00264
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Wei-Ning Huang <wnhuang at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Wei-Ning Huang <wnhuang at google.com>
Gerrit-Reviewer: build bot (Jenkins)