[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: work around full retrain constraints o...

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/19483 )

Change subject: soc/intel/apollolake: work around full retrain constraints on warm reset
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19483/2/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

PS2, Line 275: halt();
why halt? you should be dead already, besides hard_reset does it own


-- 
To view, visit https://review.coreboot.org/19483
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9a3de1fa8760e7bb2f06eef93a0deb9dbd3f047
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes