[coreboot-gerrit] Change in coreboot[master]: intel/kblrvp: Enable audio in RVP7 and RVP3

Naresh Solanki (Code Review) gerrit at coreboot.org
Thu Apr 27 20:35:19 CEST 2017


Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/18875 )

Change subject: intel/kblrvp: Enable audio in RVP7 and RVP3
......................................................................


Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/18875/5/src/mainboard/intel/kblrvp/hda_verb.c
File src/mainboard/intel/kblrvp/hda_verb.c:

PS5, Line 55: 
            : 	/*
            : 	 * IoBufferOwnership 0:HD-A Link, 1:Shared HD-A Link and I2S Port,
            : 	 * 
> Please use correctly formatted multi-line comment.
Done


https://review.coreboot.org/#/c/18875/5/src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h
File src/mainboard/intel/kblrvp/variants/rvp3/include/variant/hda_verb.h:

Line 31: 	 */
> Remove this line?
Done


-- 
To view, visit https://review.coreboot.org/18875
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27e3cf585b93ed4131d7bf3d3b53d3f5404b18e
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list