[coreboot-gerrit] Change in coreboot[master]: kblrvp: Enable audio in RVP7 and RVP3

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18875 )

Change subject: kblrvp: Enable audio in RVP7 and RVP3
......................................................................


Patch Set 5:

(4 comments)

https://review.coreboot.org/#/c/18875/5/src/mainboard/intel/kblrvp/hda_verb.c
File src/mainboard/intel/kblrvp/hda_verb.c:

PS5, Line 50: (dev == NULL)
need to check for dev->chip_info != NULL?


PS5, Line 63: dev
Check for !dev?


Line 68: 
extra blank line


PS5, Line 70: printk(BIOS_DEBUG, "HDA: base = %p\n", base);
don't you need to include console/console.h for this?


-- 
To view, visit https://review.coreboot.org/18875
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27e3cf585b93ed4131d7bf3d3b53d3f5404b18e
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes