[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/firmware: Keep CHECK_ME disabled by default

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19257 )

Change subject: sb/intel/common/firmware: Keep CHECK_ME disabled by default
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19257/1//COMMIT_MSG
Commit Message:

PS1, Line 9: Keeping CHECK_ME unset by default.
> Please add the issue that is being fixed to the commit message.
IMO this option is only useful if people are messing with their ME binary.

I don't really like passing my crafted ME binary through some unknown script when I build an image because I don't know what it might be doing to the binary.  (in theory this is just a check, but since the tool is called me_cleaner.py I don't trust it by default)


-- 
To view, visit https://review.coreboot.org/19257
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3186498c8da307b686c06c3828e24acbc7f2d17
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes