[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common smbus code
Aamir Bohra (Code Review)
gerrit at coreboot.org
Thu Apr 27 15:47:44 CEST 2017
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )
Change subject: soc/intel/common/block: Add Intel common smbus code
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/19372/4/src/soc/intel/common/block/smbus/smbus.c
File src/soc/intel/common/block/smbus/smbus.c:
PS4, Line 23: #include <soc/smbus.h>
> you need this for soc_pci_ops? all the IPs which use will have to include
Yes.OK.Removed the reference to soc_pci_ops,revised ps#5 to use local definition
PS4, Line 95: &scan_smbus
> Thinking otherwise, do we need to set this?
Yes.It sets subsystem vendor id,essential to distinguish devices with same vendor and device id.
PS4, Line 95: &scan_smbus
> soc_pci_ops in both APL and SKL is only updating .set_subsystem and both of
Done
--
To view, visit https://review.coreboot.org/19372
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I936143a334c31937d557c6828e5876d35b133567
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list