[coreboot-gerrit] Change in coreboot[master]: mb/google/eve: switch touchpad devicetree to i2c-hid and cro...

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19461 )

Change subject: mb/google/eve: switch touchpad devicetree to i2c-hid and cros_ec i2c device
......................................................................


Patch Set 3: Code-Review+2

After putting together the kernel and EC patches to see what is happening on those sides of the puzzle, I think this is the best way to handle the device probing for now since we need to supply the slave address for the EC interface in the board. (and I don't want to hack it with a #define)

If we start to use this driver in more places I can put together a separate driver that would produce both ACPI devices.

-- 
To view, visit https://review.coreboot.org/19461
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf14f7b8aed836120569e9ade9c3115bc00264
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Wei-Ning Huang <wnhuang at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Gwendal Grignou <gwendal at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Wei-Ning Huang <wnhuang at google.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No