[coreboot-gerrit] Change in coreboot[master]: Revert "amd/pi/hudson: Move ACPI IO registers"

[Marc Jones (Code Review)]

Marc Jones has submitted this change and it was merged. ( https://review.coreboot.org/19454 )

Change subject: Revert "amd/pi/hudson: Move ACPI IO registers"
......................................................................


Revert "amd/pi/hudson: Move ACPI IO registers"

This reverts commit e7394ca90366d35ac52416c21052a3ceb459dc81.

Configuration register for ACPI PM base address is initially configured
inside the PI blob. Therefore, the value of HUDSON_ACPI_IO_BASE needs
to be the same as DFLT_ACPI_PM1_EVT_BLOCK_ADDRESS used in the build
of binaryPI blob.

Change-Id: I36700e49e21cc675e8e22b06efffb40e9c1e4236
Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
Reviewed-on: https://review.coreboot.org/19454
Reviewed-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Tested-by: build bot (Jenkins)
---
M src/southbridge/amd/pi/hudson/hudson.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Marshall Dawson: Looks good to me, approved
  build bot (Jenkins): Verified



diff --git a/src/southbridge/amd/pi/hudson/hudson.h b/src/southbridge/amd/pi/hudson/hudson.h
index baed2c3..e20238f 100644
--- a/src/southbridge/amd/pi/hudson/hudson.h
+++ b/src/southbridge/amd/pi/hudson/hudson.h
@@ -51,7 +51,7 @@
 #define PM_YANG_SD_FLASH_CTRL		0xE8
 #define PM_PCIB_CFG			0xEA
 
-#define HUDSON_ACPI_IO_BASE		0x600
+#define HUDSON_ACPI_IO_BASE		0x800
 #define ACPI_PM_EVT_BLK		(HUDSON_ACPI_IO_BASE + 0x00) /* 4 bytes */
 #define ACPI_PM1_CNT_BLK	(HUDSON_ACPI_IO_BASE + 0x04) /* 2 bytes */
 #define ACPI_PM_TMR_BLK		(HUDSON_ACPI_IO_BASE + 0x18) /* 4 bytes */

-- 
To view, visit https://review.coreboot.org/19454
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36700e49e21cc675e8e22b06efffb40e9c1e4236
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins)